Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds eslint configs and deps #290

Merged
merged 3 commits into from
Aug 14, 2024
Merged

feat: Adds eslint configs and deps #290

merged 3 commits into from
Aug 14, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Aug 13, 2024

Acceptance Criteria

  • Adds linting and formatting dev dependencies to the project
  • Adds configuration for linting and formatting

Notes

The rules included were the ones that were recently agreed upon by HathorNetwork/hathor-wallet-lib#669 , only adapted to a javascript-only web project.

Since the lint/format dependencies also had to be included on the project now, and this generates a lot of reviewable changes, this PR will not actually change any code and will not modify the CI.

Also, some of the rules added here are probably redundant or not necessary. This will be investigated later, but will be kept now to help with maintaining the same linting ruleset across our repositories.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the enhancement New feature or request label Aug 13, 2024
@tuliomir tuliomir self-assigned this Aug 13, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner August 13, 2024 16:20
We need to maintain compatibility with `react-scripts` v3
and `eslint` v6
Improves code compatibility with the fullnode endpoints
@tuliomir tuliomir merged commit ea058eb into dev Aug 14, 2024
1 check passed
@tuliomir tuliomir deleted the feat/eslint branch August 14, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants